Re: [PATCH] tmpfs: add padding to tmpfs_dirent structure

[Samuel Thibault]

Sergio Lopez, le Wed 19 May 2010 17:33:39 +0200, a écrit :
> El Wed, 19 May 2010 16:05:27 +0200
> Carl Fredrik Hammar <hammy.lite@gmail.com> escribió:
> 
> > On Tue, May 18, 2010 at 04:19:34PM +0200, Sergio Lopez wrote:
> > > 
> > > This patch adds some padding to tmpfs_dirent structure as it's
> > > suggested in the wiki
> > > (http://www.gnu.org/software/hurd/hurd/translator/tmpfs.html).
> > > 
> > 
> > It seems Samuel beat you to it back in January: see commit 97c569.
> > 
> 
> Humm... I didn't see that. Anyway, I think that change should be
> reverted and the assertion in diskfs_get_directs removed.

Err, why removing it?  Isn't there a need for the whole struct dirent
structure to be allocated or something like that?  (Which probably was
the reason for the assertion).

Samuel