Re: [Fwd: Questions on isc-dhcp]

[Svante Signell]

On Thu, 2011-03-03 at 09:41 +0100, Samuel Thibault wrote:
> Svante Signell, le Thu 03 Mar 2011 08:22:06 +0100, a écrit :
> > Q: Should I mention the patch in bug 602312, needed for a successful
> > build from source?
> 
> No need to, that's a separate bug.

Sorry, too late, bug report just submitted. Hopefully a minor issue.

> > C: I see that you used #ifdefs in the source code, instead of trying to
> > find one way of writing the code. I was communicating with upstream of
> > another package, and he did not like this kind of constructs, it was
> > just cluttering the code. Any recommendations?
> 
> One can't avoid ifdefs if one wants to use the extension
> realpath(foo,NULL). If one wants to avoid both PATH_MAX and ifdef, you'd
> need an allocation loop etc., which I think clutters the code even more.

Yes, I agree.

Thank you for helping be with this, I've learned a lot. Still much more
to learn to be really able to contribute.