[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnumach: vm: zone_gc: Got rid of useless function

From: Richard Braun
Subject: Re: [PATCH] gnumach: vm: zone_gc: Got rid of useless function
Date: Tue, 19 Apr 2011 09:46:59 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Apr 18, 2011 at 10:05:57PM +0200, Samuel Thibault wrote:
> I don't think this patch can be applied. Building a list and then
> freeing it was done for some reason, at least because kmem_free, (thus
> vm_map_delete), may actually need to use zalloc in order to split
> some areas (which is actually the reason for the double map_entry
> allocation/release), which thus needs to lock the zone, and thus ends up
> with a deadlock.

This change seems rather dangerous. It brings no real improvement while
adding a potential deadlock.

In addition to avoiding deadlocks, freeing list elements in two steps
is also a technique commonly used to reduce contention.

Richard Braun

reply via email to

[Prev in Thread] Current Thread [Next in Thread]