[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ChangeLog/commit messages (was: [PATCH] utils/vmstat: Be less aggressive

From: Thomas Schwinge
Subject: ChangeLog/commit messages (was: [PATCH] utils/vmstat: Be less aggressive about switching to bigger units)
Date: Wed, 07 Sep 2011 17:06:09 +0200
User-agent: Notmuch/0.7-57-g64222ef (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu)


On Mon, 22 Aug 2011 01:26:21 +0200, Samuel Thibault <samuel.thibault@gnu.org> 
> olafBuddenhagen@gmx.net, le Sat 23 Jul 2011 01:50:16 +0200, a écrit :
> > Instead of switching to the next bigger unit as soon as the value
> > exceeds 1024, do so only when it gets larger than four digits.
> Applied, thanks.
> Please see the changelog I have used instead.

Yes, I assume we still need to keep going with the standard GNU practices
of having per-file/function ChangeLogs.

On the other hand, comments such as Olaf's quoted above (``Instead of
[...]'') should in fact not be put into the ChangeLog/commit message, but
should be put (in a slightly altered form, of course) into the code
itself: to describe the logic/where the 10000 constant is coming from.
Looking at the code now it may be obvious, but perhaps not anymore in a
few months.

So, if we assume that there's nothing wrong with including more
descriptive text in the commit messages, and unless there are any
objections from the other maintainers or the general public, I'll amend
the text about ``Commit messages'' on
<http://www.gnu.org/software/hurd/source_repositories.html> accordingly.

On other news, I recently added Olaf to the Savannah hurd group.  I guess
he doesn't need any introduction anymore.  Welcome!  (Olaf, as you've
already seen, this does give me the power to assign Savannah tasks to
you.)  ;-P


Attachment: pgpe3RPHqovyi.pgp
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]