[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH gnumach] Inline version.m4 into configure.ac
From: |
Guillem Jover |
Subject: |
[PATCH gnumach] Inline version.m4 into configure.ac |
Date: |
Thu, 10 Nov 2011 04:49:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi!
On Tue, 2011-11-08 at 00:13:51 +0100, Thomas Schwinge wrote:
> In GNU Mach, we have a version.m4 where these fields are defined one and
> for all. (I argue that a package's version definition does not really
> belong into a generic, otherwise version-agnostic configuration system's
> file.) (But on the other hand, *version*.m4 is likely not the most
> suitable name for defining a package's name.) (Are we bike-shedding
> yet?)
I introduced that file because at the time the source tree had multiple
configure.in, so sharing the definitions seemed saner. But then this
could have been merged back once the build system was converted to a
single configure.ac. The attached patch does just that.
Regarding the definition of the version, I tend to agree, and I'd say
it should be generated automatically from the nearest git tag (but
then gnumach does not have any tags right now :). There's such a script
in gnulib (git-version-gen) that could be used, if GPL3+ would be an
issue I implemented a similar one but GPL2+ for dpkg (get-version)
some time ago.
thanks,
guillem
0001-Inline-version.m4-into-configure.ac.patch
Description: Text Data
- [PATCH] Provide modern Autoconf initialization, Ludovic Courtès, 2011/11/07
- Re: [PATCH] Provide modern Autoconf initialization, Samuel Thibault, 2011/11/07
- Re: [PATCH] Provide modern Autoconf initialization, Ludovic Courtès, 2011/11/07
- [PATCH gnumach] Inline version.m4 into configure.ac,
Guillem Jover <=
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Thomas Schwinge, 2011/11/10
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Guillem Jover, 2011/11/11
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Svante Signell, 2011/11/12
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Ludovic Courtès, 2011/11/12
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Ludovic Courtès, 2011/11/10
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Thomas Schwinge, 2011/11/20
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Guillem Jover, 2011/11/20
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Ludovic Courtès, 2011/11/20
- Re: [PATCH gnumach] Inline version.m4 into configure.ac, Thomas Schwinge, 2011/11/20
- Re: [PATCH] Provide modern Autoconf initialization, Thomas Schwinge, 2011/11/10