[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] sendto: do not crash when addr is NULL

From: Pino Toscano
Subject: Re: [PATCH,HURD] sendto: do not crash when addr is NULL
Date: Thu, 7 Jun 2012 20:46:05 +0200
User-agent: KMail/1.13.7 (Linux/3.2.0-2-amd64; KDE/4.7.4; x86_64; ; )


Alle lunedì 21 maggio 2012, Roland McGrath ha scritto:
> Put the name of a local variable in all caps when mentioning it in
> the log entry or comments.

Noted, and done.

> It looks like the existing code also has a leak of APORT in the case
> where HURD_DPORT_USE fails (i.e. invalid fd).  So you should
> reorganize in some way that fixes that too.


> It might be simplest just to move the creation of the address port
> (both the AF_LOCAL case and the default case) into a subroutine and
> just call that inside HURD_DPORT_USE.  It means that the descriptor
> structure and port are kept alive around the AF_LOCAL case's calls,
> but that seems OK.


Updated patch attached.

Pino Toscano

Attachment: hurd_sendto.diff
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]