bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Page cache accounting


From: Neal H. Walfield
Subject: Re: [PATCH] Page cache accounting
Date: Sun, 15 Jul 2012 18:39:05 +0200
User-agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

At Sat, 14 Jul 2012 17:06:37 +0200,
Richard Braun wrote:
> 
> If no major objection is raised (particularly about the new Mig
> routine), I'll commit this patch in a few days.
> ...
> +struct vm_cache_statistics {
> +     integer_t       object_count;   /* # of cached objects */
> +     integer_t       page_count;     /* # of cached pages */
> +     integer_t       _reserved[14];
> +};

I'd encourage you to use a more self-describing data structure.  In
the very least, please consider a version number and a bitmask
indicating which fields are valid.

Neal



reply via email to

[Prev in Thread] Current Thread [Next in Thread]