[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] sendto: do not crash when addr is NULL

From: Pino Toscano
Subject: Re: [PATCH,HURD] sendto: do not crash when addr is NULL
Date: Fri, 20 Jul 2012 18:54:49 +0200
User-agent: KMail/1.13.7 (Linux/3.2.0-3-amd64; KDE/4.8.4; x86_64; ; )


Alle mercoledì 13 giugno 2012, Pino Toscano ha scritto:
> Alle martedì 12 giugno 2012, Roland McGrath ha scritto:
> > That's almost right, but you should avoid calling
> > __mach_port_deallocate if APORT is MACH_PORT_NULL.  Also, avoid
> > shadowing the local variable ERR with one of the same name in the
> > subfunction.
> Hm ok, I saw other cases of shadowing by internal subroutines, and
> assumed it was okay (since inside them you want to refer to the local
> "err" instead of the outermost one.
> Thanks for the further review, patch attached.
> (I would use the non-ChangeLog lines of the patch header as commit
> log, would that be okay?)

Ping, about this and the other glibc patches I sent and that are 
awaiting review.

Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]