[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurdselect: Step1, code split preparations

From: Samuel Thibault
Subject: Re: [PATCH,HURD] hurdselect: Step1, code split preparations
Date: Tue, 22 Jan 2013 19:01:13 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Svante Signell, le Tue 22 Jan 2013 18:53:43 +0100, a écrit :
> Attached is the first patch for a 3-way split of hurdselect.c into three
> cases: DELAY, POLL, SELECT leading to a more POSIX conforming POLL.

It is way more readable that the previous versions :)

> +  if (nfds > _hurd_dtablesize)
> +    nfds = _hurd_dtablesize;

You can't afford moving that to the general case: in the poll case, nfds
is not the maximum of the fds, but the number of elements in the array,
which can be very big, if the application puts the same fd several time
in the array.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]