[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finish

From: Richard Braun
Subject: Re: [PATCH,HURD][RFC] hurdselect: Step7x, almost complete rewrite finished
Date: Wed, 13 Feb 2013 00:30:05 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

On Wed, Feb 13, 2013 at 12:12:57AM +0100, Svante Signell wrote:
> What a pity, I spent a very long time doing this rewrite, and to make
> the code more readable (at least in my opinion). Back to spaghetti^Wold
> style code then.

We warned you several times about making your changes as little
intrusive as possible for easier review. Since you seem to be unable to
understand what that implies, it's only natural Samuel no longer wastes
time on this and simply replies "to long to go through it".

You have to understand that whether the code looks "spaghetti" or not,
your goal here is not to fix that, it's to fix a POSIX conformance
issue. If you want to refactor, fine, but please separate it. It's
really important to make as little change as possible for two reasons.
The first is the obvious comfort for the reviewers. If it's easier for
us, it's also faster, and we can more effectively concentrate on
thinking about the big picture and the details. The second is to reduce
the likeliness of regressions. Please keep that in mind.

Richard Braun

reply via email to

[Prev in Thread] Current Thread [Next in Thread]