[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnumach/ddb: use and cleanup db_print.h

From: Samuel Thibault
Subject: Re: [PATCH] gnumach/ddb: use and cleanup db_print.h
Date: Fri, 5 Jul 2013 00:15:29 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Tue 02 Jul 2013 11:41:55 +0200, a écrit :
> So, I made a preliminary patch with db_print.h. I don't really know if 
> this is an improvement over having extern statements in db_command.c. 

It is: by making the .c file (that defines the function) include the .h
file, it permits to make sure that both the caller and the callee do
really agree on the way the function is called.

>  extern void  db_listbreak_cmd();
>  extern void  db_listwatch_cmd();
> -extern void  db_show_regs(), db_show_one_thread(), db_show_one_task();
> +extern void  db_show_one_thread();
>  extern void  db_show_all_threads();

etc.  Ideally all these would go into common .h files.

Applied, thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]