[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH, gnumach] ddb: fix implicit declarations

From: Marin Ramesa
Subject: Re: [PATCH, gnumach] ddb: fix implicit declarations
Date: Fri, 05 Jul 2013 14:55:32 +0200

On 05.07.2013 09:45:39, Samuel Thibault wrote:
> Err, no, the point of putting it in a .h file is to put it into a
> single place, so you're sure everybody agree on the definition since 
> it's written only once. The .h file where it's supposed to go has to 
> be related with the function itself, e.g. here i386/i386/setjmp.h 
> seems like a good candidate.

Of course, it was obvious. They all (kern/xpr.c, ddb/db_command.c, ddb/
db_cond.c) contain conditional includes for <machine/setjmp.h>. Putting 
'extern int _setjmp(jmp_buf_t*)' to i386/i386/setjmp.h removes three 
implicit declaration warnings.

Thanks for explaining this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]