[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.

From: Ivan Shmakov
Subject: Re: [PATCH 8/8] sysvinit: Fix getty path in /etc/inittab on Hurd.
Date: Tue, 09 Jul 2013 10:59:01 +0000
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux)

>>>>> Justus Winter <4winter@informatik.uni-hamburg.de> writes:

 > This is essentially the same as
 > 89f6476d8979174f395a1bf784486254464c349d but fixes the existing
 > /etc/inittab file in the postinstall script.


 > +  * sysvinit.postinst: Fix getty path in /etc/inittab on Hurd.

        Please note that the GNU Coding Standards recommend to use the
        “file name” term here instead:

--cut: https://www.gnu.org/prep/standards/standards.html --
    Please do not use the term “pathname” that is used in Unix
    documentation; use “file name” (two words) instead.  We use the term
    “path” only for search paths, which are lists of directory names.
--cut: https://www.gnu.org/prep/standards/standards.html --

        (The last component of a file name — that is, a file name
        without the leading directories — could then presumably be
        called “base name.”)


 > +if [ "$(uname)" = GNU ]; then
 > +    sed -i -e 's|/libexec/getty|/sbin/getty|' /etc/inittab

        I don’t seem to understand.  Shouldn’t it be the other way

        But overall, I doubt that this change is necessary.  If the
        package is being upgraded, the chances are that this defect was
        already corrected by the user.  And for the new installations,
        wasn't this issue already fixed?

 > +fi
 > +

FSF associate member #7257

reply via email to

[Prev in Thread] Current Thread [Next in Thread]