[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/3] Revert "tmpfs: drop privileges in the tmpfs translator"

From: Justus Winter
Subject: [PATCH 1/3] Revert "tmpfs: drop privileges in the tmpfs translator"
Date: Tue, 8 Oct 2013 15:49:02 +0200

This reverts commit 7075bc11289355478659cd1610632a9299734afc.

Dropping the unix privileges of the tmpfs translator causes problems
with the passive translator startup. The function fshelp_fetch_root
creates an auth handle containing the processes original UID and
GID. But if the privileges were dropped before, this operation fails
with EPERM.

This commit also broke mkfifo(3), possibly for similar or related

* tmpfs/tmpfs.c (main): Do not drop all privileges.
 tmpfs/tmpfs.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/tmpfs/tmpfs.c b/tmpfs/tmpfs.c
index 1872a7d..7da3dd5 100644
--- a/tmpfs/tmpfs.c
+++ b/tmpfs/tmpfs.c
@@ -29,7 +29,6 @@ the Free Software Foundation, 675 Mass Ave, Cambridge, MA 
02139, USA.  */
 #include <fcntl.h>
 #include <hurd.h>
 #include <hurd/paths.h>
-#include <nullauth.h>
 char *diskfs_server_name = "tmpfs";
 char *diskfs_server_version = HURD_VERSION;
@@ -438,11 +437,6 @@ main (int argc, char **argv)
   /* We must keep the REALNODE send right to remain the active
      translator for the underlying node.  */
-  /* Drop all privileges.  */
-  err = setnullauth();
-  if (err)
-    error (1, err, "Could not drop privileges");
   pthread_mutex_unlock (&diskfs_root_node->lock);
   /* and so we die, leaving others to do the real work.  */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]