[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] device: fix enqueuing of characters in ttyinput_many
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 1/2] device: fix enqueuing of characters in ttyinput_many |
|
Date: |
Tue, 5 Nov 2013 00:59:39 +0100 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 04 Nov 2013 19:18:34 +0100, a écrit :
> Fix enqueuing of characters in ttyinput_many by wrapping the call to
> b_to_q in a loop. This was probably intended by the authors, as they
> subtract the number of enqueued characters from count.
Mmm, I don't think so actually, see the content of b_to_q, it usually
does the while loop already, unless there is no room any more. Calling
it again in a loop would just hang. The function would probably be
meant to return the decremented count.
All that being said, I don't see any caller for the function...
Samuel