[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] device: initialize to zero offset
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 1/2] device: initialize to zero offset |
Date: |
Sun, 10 Nov 2013 16:52:53 +0100 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Sun 10 Nov 2013 16:46:29 +0100, a écrit :
> Initialize addr to zero offset to quiet warnings about uninitialized
> deallocation.
>
> * device/chario.c (addr): Initialize to zero.
Applied, thanks.
> ---
> device/chario.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/device/chario.c b/device/chario.c
> index c40705e..19f3bae 100644
> --- a/device/chario.c
> +++ b/device/chario.c
> @@ -260,7 +260,7 @@ io_return_t char_write(
> spl_t s;
> int count;
> char *data;
> - vm_offset_t addr;
> + vm_offset_t addr = 0;
> io_return_t rc = D_SUCCESS;
>
> data = ior->io_data;
> --
> 1.8.1.4
>
>
--
Samuel
/* Amuse the user in a SPARC fashion */
if (err) printk(
KERN_CRIT " _______________________________ \n"
KERN_CRIT " < Your System ate a SPARC! Gah! >\n"
KERN_CRIT " ------------------------------- \n"
KERN_CRIT " \\ ^__^\n"
KERN_CRIT " \\ (xx)\\_______\n"
KERN_CRIT " (__)\\ )\\/\\\n"
KERN_CRIT " U ||----w |\n"
KERN_CRIT " || ||\n");
(From linux/arch/parisc/kernel/traps.c:die_if_kernel())