Re: [PATCH 2/5] kern (rbtree_insert_rebalance): rewrite node swap

[Samuel Thibault]

Richard Braun, le Tue 12 Nov 2013 11:56:05 +0100, a écrit :
> On Sun, Nov 10, 2013 at 11:00:26PM +0100, Samuel Thibault wrote:
> > Marin Ramesa, le Sun 10 Nov 2013 22:50:21 +0100, a écrit :
> > > Value of node is never read. Simplify the node swap to one assignment
> > > and remove the temporary variable.
> > > 
> > > * kern/rbtree.c (rbtree_insert_rebalance): Simplify node swap.
> > 
> > I'd rather keep it as such, as an expression of the rbtree rotation.
> 
> It's not a rotation, merely a variable swap,

Ok, but below the comment says

/* Node is the left child of its parent. */

If node is not always updated at this point, the comment does not make
sense any more.

Samuel