[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] i386/i386/db_trace.c: make function void
From: |
Marin Ramesa |
Subject: |
Re: [PATCH 5/5] i386/i386/db_trace.c: make function void |
Date: |
Thu, 21 Nov 2013 19:02:34 +0100 |
On 21.11.2013 18:58:28, Samuel Thibault wrote:
> Marin Ramesa, le Thu 21 Nov 2013 18:56:09 +0100, a écrit :
> > On 21.11.2013 18:50:20, Samuel Thibault wrote:
> > > Marin Ramesa, le Thu 21 Nov 2013 18:48:40 +0100, a écrit :
> > > > On 21.11.2013 18:19:52, Samuel Thibault wrote:
> > > > > Marin Ramesa, le Thu 21 Nov 2013 13:11:08 +0100, a écrit :
> > > > > > - { "cs", (long *)&ddb_regs.cs,
> db_i386_reg_value
> > > },
> > > > > > + { "cs", (long *)&ddb_regs.cs, (void
> > > > *)db_i386_reg_value },
> > > > >
> > > > > Mmm, you shouldn't need this cast.
> > > >
> > > > GCC complains otherwise. I did not know what else to do.
> > >
> > > Well, show us the complain :)
> >
> > ../i386/i386/db_trace.c:60:2: warning: initialization from
> > incompatible pointer type
> > ../i386/i386/db_trace.c:60:2: warning: (near initialization for
> > „db_regs[0].fcn”)
>
> Mmm, you didn't modify the struct db_variable, so that's not
> surprising
> :)
It's used in other places. I think modification would break things.
- Re: [PATCH 2/5] ddb/db_sym.c: move assignment outside if, (continued)
[PATCH 3/5] i386/i386at/kd.h: fix implicit declaration of function, Marin Ramesa, 2013/11/21
[PATCH 4/5] i386/i386/db_interface.h: fix implicit declaration of function, Marin Ramesa, 2013/11/21
[PATCH 5/5] i386/i386/db_trace.c: make function void, Marin Ramesa, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Samuel Thibault, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Marin Ramesa, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Samuel Thibault, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Marin Ramesa, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Samuel Thibault, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void,
Marin Ramesa <=
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Samuel Thibault, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Samuel Thibault, 2013/11/21
- Re: [PATCH 5/5] i386/i386/db_trace.c: make function void, Marin Ramesa, 2013/11/21