Re: [PATCH 09/11] libports: improve error reporting in adjust_priority

[Samuel Thibault]

Justus Winter, le Wed 27 Nov 2013 13:31:16 +0100, a écrit :
> By using error instead of perror, the warning can be proprely
> attributed to the process.
> 
> * libports/manage-multithread.c (adjust_priority): Use error instead
>   of perror to print the warning.

Ack.

> ---
>  libports/manage-multithread.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libports/manage-multithread.c b/libports/manage-multithread.c
> index d034582..be08030 100644
> --- a/libports/manage-multithread.c
> +++ b/libports/manage-multithread.c
> @@ -20,6 +20,7 @@
>  
>  #include "ports.h"
>  #include <assert.h>
> +#include <error.h>
>  #include <stdio.h>
>  #include <mach/message.h>
>  #include <mach/thread_info.h>
> @@ -82,10 +83,7 @@ out:
>      mach_port_deallocate (mach_task_self (), pset_priv);
>  
>    if (err && err != EPERM)
> -    {
> -      errno = err;
> -      perror ("unable to adjust libports thread priority");
> -    }
> +    error (0, err, "unable to adjust libports thread priority");
>  }
>  
>  void
> -- 
> 1.7.10.4
> 

-- 
Samuel
#ifndef I_WISH_WORLD_WERE_PERFECT
/* It is not :-( All the routers (except for Linux) return only
...
 -+- linux/net/ipv4/ipip.c -+-