bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead o


From: Samuel Thibault
Subject: Re: [PATCH 16/28] ddb/db_command.c (db_command): use db_addr_t instead of db_expr_t
Date: Mon, 9 Dec 2013 00:54:30 +0900
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Sun 08 Dec 2013 12:40:18 +0100, a écrit :
> In this way there are two casts less.

Yes, but

> -         addr = (db_expr_t)db_next;

This kind of cast is preferrable to 

> +             if (db_expression((db_expr_t *)&addr)) {

that one, because whatever the actual sizes, the first is correct, while
the second won't necessarily.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]