Re: [PATCH v14] kern: simple futex for gnumach

[Marin Ramesa]

On 01/13/2014 06:28:44 PM, Richard Braun wrote:
> On Mon, Jan 13, 2014 at 03:38:19PM +0100, Marin Ramesa wrote:
> > Fixed a bug in private wakeups by calling ipc_entry_alloc_name().
> >
> > This is the last version as everything works now.
>
> *Sigh*
>
> You didn't understand my comment mentioning IPC spaces at all... You
> keep wrongly using the red-black tree interface. You keep making basic
> locking mistakes. You still pass raw addresses/values instead of  
> passing
> *memory*. You obviously didn't take the time to look at how  
> assert_wait
> and thread_will_wait_with_timeout were used elsewhere and implemented.
> You didn't change the timeout parameter type, despite your claim for a
> "final version". And worst of all, you dare claim "everything works".
>
> You clearly have little clue about what you're actually doing, and  
> don't
> make the effort to check your assumptions and learn. I won't review  
> any
> more of your work.

Thanks for your reviews, I learned a lot. I won't take up your time  
anymore.
I will do this privately from now on, so I don't bother people on the
mailing list with my patches.

Justus, thanks for the comments.