Re: [PATCH 06/11] libstore: provide function declaration until available upstream

[Samuel Thibault]

Justus Winter, le Thu 22 May 2014 22:13:28 +0200, a écrit :
> Until the Hurd specific header is available, provide a local
> declaration of ped_device_new_from_store.

Mmm, does it really fix something?  I'd prefer to keep the warning
showing up, so somebody eventually takes the time to provide a header.
Otherwise we'll just hide a warning, and possibly nobody will eventually
take the time to actually fix it.

> * libstore/part.c (ped_device_new_from_store): New declaration.
> ---
>  libstore/part.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/libstore/part.c b/libstore/part.c
> index 56e904e..fb7f07e 100644
> --- a/libstore/part.c
> +++ b/libstore/part.c
> @@ -26,6 +26,16 @@
>  
>  #include <parted/parted.h>
>  /*#include <parted/device_gnu.h>*/
> +
> +/* XXX Until the Hurd specific header is available, provide the
> +   declaration of ped_device_new_from_store here.  */
> +
> +/* Initialize a PedDevice using SOURCE.  The SOURCE will NOT be destroyed;
> +   the caller created it, it is the caller's responsilbility to free it
> +   after it calls ped_device_destory.  SOURCE is not registered in Parted's
> +   list of devices.  */
> +PedDevice* ped_device_new_from_store (struct store *source);
> +
>  #include <string.h>
>  #include <error.h>
>  
> -- 
> 2.0.0.rc2
> 

-- 
Samuel
 Cliquez sur le lien qui suit dans ce mail...vous n'avez plus qu'a vous
 inscrire pour gagner de l'argent en restant connecte....et puis faites
 passer le message et vous gagnerez encore plus d'argent ...
 -+- AC in NPC : Neuneu a rencontré le Pere Noël -+-