Re: GSOC - valgrind-hurd queries

[Subhashish]

On Saturday 31 May 2014 06:32 AM, Samuel Thibault wrote:
> Subhashish, le Sat 31 May 2014 06:23:39 +0530, a écrit :
> > Now since I've #include-ed "i386-gnu/bits/resource.h", do I need to #define
> > the RLIMIT_* symbols with VKI_ prefixes?
> >
> > vki-linux.h doesn't but darwin's does.
> vki-linux does, in the vki-*-linux.h files.
>
> > Moreover, ours are inside eums, so maybe I think they will be
> > automatically picked up by rlimit and friends.
> But valgrind uses VKI_RLIMIT_* macros, not RLIMIT_* macros, so you have
> to define the former.
>
> Now, AIUI valgrind redefines everything from scratch, without using
> system headers.  It seems darwin does use system headers, but AIUI it's
> not the way it's supposed to be done: vki-*.h redefines everything that
> coregrind needs from scratch.
>
> Samuel
Thanks for that timely information :) I was following darwin's style. 
Indeed vki-linux borrows the code.
Is that the proper convention - I think so since valgrind was originally 
written for linux.

The argument for darwin's as presented in its beginning notes/docs was - 
since both were gpl licensed (the xnu and valgrind) the headers were 
directly #includ-ed.
But now I'll have to be more careful to avoid importing of declarations 
beyond our use.

I'll just change them.

Subhashish