[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] trans/fakeroot: fix error handling
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 3/5] trans/fakeroot: fix error handling |
Date: |
Wed, 18 Jun 2014 00:34:36 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Justus Winter, le Mon 16 Jun 2014 19:49:27 +0200, a écrit :
> Found using the Clang Static Analyzer.
>
> * trans/fakeroot.c (new_node): Do not leak a pointer to freed memory.
> Store NULL at *np instead. This fixes a node use-after-free in
> netfs_S_dir_lookup.
Ack.
> ---
> trans/fakeroot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/trans/fakeroot.c b/trans/fakeroot.c
> index 32a34ec..df2de64 100644
> --- a/trans/fakeroot.c
> +++ b/trans/fakeroot.c
> @@ -119,6 +119,7 @@ new_node (file_t file, mach_port_t idport, int locked,
> int openmodes,
> mach_port_deallocate (mach_task_self (), nn->idport);
> mach_port_deallocate (mach_task_self (), file);
> free (*np);
> + *np = NULL;
> return err;
> }
>
> --
> 2.0.0
>
--
Samuel
«Tiens, quand j'aurai un peu de temps et une partition libre, je crois
que je vais essayer de remplacer mes scripts de démarrage par des
programmes Windows lancés via Wine et binfmt_misc :-)»
-+- AGV in Guide du linuxien pervers - "J'sais pas quoi faire... (air connu)"
- [PATCH 1/5] ftpfs: fix error handling in refresh_dir, Justus Winter, 2014/06/16
- [PATCH 2/5] libshouldbeinlibc: fix dead initialization in fmt_named_interval, Justus Winter, 2014/06/16
- [PATCH 4/5] libports: avoid realloc(3) corner case, Justus Winter, 2014/06/16
- [PATCH 3/5] trans/fakeroot: fix error handling, Justus Winter, 2014/06/16
- Re: [PATCH 3/5] trans/fakeroot: fix error handling,
Samuel Thibault <=
- [PATCH 5/5] libdiskfs: add permission check to file_chflags, Justus Winter, 2014/06/16
- Re: [PATCH 1/5] ftpfs: fix error handling in refresh_dir, Samuel Thibault, 2014/06/17