[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Conflicting ‘thread_info_t’ declaration between nscd and Mach
From: |
Ludovic Courtès |
Subject: |
Re: Conflicting ‘thread_info_t’ declaration between nscd and Mach |
Date: |
Sun, 22 Jun 2014 10:55:52 +0200 |
User-agent: |
Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) |
Pino Toscano <toscano.pino@tiscali.it> skribis:
> On Saturday 21 June 2014 23:29:43 Ludovic Courtès wrote:
>> Roland McGrath <roland@hack.frob.com> skribis:
>> > Send a patch upstream to libc to avoid using the *_t name space for
>> > non-public type names like the one in nscd. We'll take it.
>>
>> Great, will do.
>>
>> Manolis: could you confirm that the attached patch allows you to build
>> libc for the Hurd with nscd support?
>>
>> diff --git a/nscd/nscd.c b/nscd/nscd.c
>> index 5680378..c910fd5 100644
>> --- a/nscd/nscd.c
>> +++ b/nscd/nscd.c
>> @@ -61,14 +61,14 @@
>> and under a shutdown condition to wait till all in-progress
>> requests have finished before "turning off the lights". */
>>
>> -typedef struct
>> +struct thread_info
>> {
>> int num_active;
>> pthread_cond_t thread_exit_cv;
>> pthread_mutex_t mutex;
>> -} thread_info_t;
>> +};
>>
>> -thread_info_t thread_info;
>> +struct thread_info thread_info;
>
> Or what about simply getting rid of thread_info_t struct and thread_info
> variable, since they don't seem to be used at all within nscd?
Indeed, I had overlooked that.
> (Of course, that would require testing also on Linux.)
I’ll try it.
Ludo’.