[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] utils/mount: canonicalize mountpoints

From: Samuel Thibault
Subject: Re: [PATCH] utils/mount: canonicalize mountpoints
Date: Wed, 1 Oct 2014 00:53:37 +0200
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Getting back to this old thread so we may get pbuilder to work...

Samuel Thibault, le Sat 14 Jun 2014 22:44:56 +0200, a écrit :
> Gabriele Giacone, le Thu 05 Jun 2014 00:34:45 +0200, a écrit :
> > * utils/mount.c (main): realpath mountpoint.
> > * utils/umount.c (do_umount): Likewise.
> Mmm, but sutils/fstab.c already does apply realpath, doesn't it?  I see
> it doing it in fstab_find.

But umount calls fstab_find_mount and fstab_find_device, not
fstab_find.  I'd thus say that these former should apply the realpath
instead of fstab_find.  Could you try this instead of adding one
to do_umount?

Conversely, we need to realpath the entries being added to fstab,
that would probably have to be done in fs_set_mntent.  Care must be
taken that mntent is const.  The simplest way is probably to just make
a copy of the struct mntent, realpath both mnt_fsname and mnt_dir,
and keep the rest of the code as such.  I believe that should thus
fix mount along the way.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]