Re: [PATCH hurd-dde 2/3] eth-multiplexer: fix device_{get,set}_status calls

[Samuel Thibault]

Justus Winter, le Fri 14 Nov 2014 19:28:07 +0100, a écrit :
> * eth-multiplexer/ethernet.c (set_promisc): Make flags an int, count
> must be 1.

Ack.

> ---
>  eth-multiplexer/ethernet.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/eth-multiplexer/ethernet.c b/eth-multiplexer/ethernet.c
> index 32c5589..886f5df 100644
> --- a/eth-multiplexer/ethernet.c
> +++ b/eth-multiplexer/ethernet.c
> @@ -76,12 +76,12 @@ int set_promisc (char *dev_name, mach_port_t ether_port, 
> int is_promisc)
>  #ifndef NET_FLAGS
>  #define NET_FLAGS (('n'<<16) + 4)
>  #endif
> -  short flags;
> +  int flags;
>    int ret;
>    size_t count;
>  
>    debug ("set_promisc is called, is_promisc: %d\n", is_promisc);
> -  count = sizeof (flags);
> +  count = 1;
>    ret = device_get_status (ether_port, NET_FLAGS, (dev_status_t) &flags, 
>                             &count);
>    if (ret) 
> @@ -93,8 +93,7 @@ int set_promisc (char *dev_name, mach_port_t ether_port, 
> int is_promisc)
>      flags |= IFF_PROMISC;
>    else
>      flags &= ~IFF_PROMISC;
> -  ret = device_set_status(ether_port, NET_FLAGS, (dev_status_t) &flags,
> -                          sizeof (flags));
> +  ret = device_set_status(ether_port, NET_FLAGS, (dev_status_t) &flags, 1);
>    if (ret) 
>      {
>        error (0, ret, "device_set_status");
> -- 
> 2.1.1
> 

-- 
Samuel
    if (argc > 1 && strcmp(argv[1], "-advice") == 0) {
        printf("Don't Panic!\n");
        exit(42);
    }
        -- Arnold Robbins in the LJ of February '95, describing RCS