[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH hurd 0/6] Add file record locking support

From: Justus Winter
Subject: Re: [PATCH hurd 0/6] Add file record locking support
Date: Thu, 08 Jan 2015 13:38:25 +0100
User-agent: alot/0.3.5

Hello Svante :)

Quoting Svante Signell (2015-01-08 12:28:05)
> Hi,
> Attached in subsequent mails is a patch series for file record locking
> support, mainly developed by Neal Walfield in 2001. The patch was
> published by Marcus Brinkmann and later re-diffed by Michael Banck in
> 2002. Now modified to use libpthread instead of cthreads and some
> additional fixes.


> 1/6: hurd_new_RPC.patch: add new RPC: file_record_lock
> 2/6: libdiskfs_file_record_lock.patch: implement
> diskfs_S_file_record_lock and modify diskfs_S_* accordingly, initialize
> and release lock_status.
> 3/6: libfshelp_rlock.patch: implement fshelp_rlock_* functions
> 4/6: libfshelp-tests_rlock.patch: implement file_record_lock tests
> 5/6: libnetfs_file_record_lock.patch: implement netfs_S_file_record_lock
> 6/6: libtrivfs_file_record_lock.patch: implement
> trivfs_S_file_record_lock

For my taste, the order of patches is wrong.  Please try to make sure,
that the source tree compiles at every point.  If you add an RPC with
the first patch, the build will break.  Instead, you have to add the
server implementation first, and the RPC definition later.

Also, use git.  This isn't optional.  If you want to contribute to a
free software project, you have to use the tools they use.  Not doing
so breaks everyones workflow.  If you had used git to send the
patches, they'd end up as a single mail thread in my client, and I'd
be able to read every patch in the comfort of my mail client.  Now
it's seven separate mails, and the patches are attachments, that I
cannot immediately see and reply to.

I will not review patches that are not sent using git, but I'm only
speaking for myself of course.

> Maybe also the copyright text should be updated to a more modern version
> for new files

Yes please.

> (and adding copyright year 2015?)

If you made a copyrightable contribution in 2015, then yes, please add
the year to the list.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]