bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket


From: Svante Signell
Subject: Re: RFC: [PATCH] Re: Test case for fakeroot-hurd failure with a socket
Date: Wed, 13 May 2015 10:31:42 +0200

On Wed, 2015-05-13 at 10:04 +0200, Samuel Thibault wrote:
> Samuel Thibault, le Wed 13 May 2015 09:57:27 +0200, a écrit :
> > > +  return file_set_translator (netfs_node_netnode (np)->file,
> > > +                       FS_TRANS_EXCL|FS_TRANS_SET,
> > > +                       FS_TRANS_EXCL|FS_TRANS_SET, 0,
> > > +                       argz, argzlen,
> > > +                       MACH_PORT_NULL, MACH_MSG_TYPE_COPY_SEND);
> > 
> > Mmm, I don't think you want to set the active_flags parameter, see the
> > comment above:
> 
> And you have set the active parameter to MACH_PORT_NULL, so active_flags
> should really be set to 0, it doesn't really make sense otherwise.

This is copeied verbatim from fakeroot.c:netfs_attempt_mksymlink() and
netfs_attempt_mkdev() so the active_flags parameter should be zero there
too?

New patch attached!

Attachment: trans_fakeroot_socket.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]