Re: [PATCH] Change file_utimes RPC to use a struct timespec and update the servers to use UTIME_NOW and UTIME_OMIT.

[Flávio Cruz]

On Sun, 30 Aug 2015 at 01:24 Samuel Thibault <samuel.thibault@gnu.org> wrote:

Hello,

Thanks for working on this!

Flávio Cruz, le Sat 29 Aug 2015 03:35:56 +0100, a écrit :
> These two patches allow the glibc and the hurd servers to handle UTIME_OMIT and UTIME_NOW in futimens.
> The file_utimes RPC now uses a struct timespec instead of a timeval.

Well, we can't really change RPCs on the fly like this, otherwise you
can't upgrade running translators first or libc first.  You need to
introduce a new RPC with the new interface, and in libc cope with
translators which don't know the new RPC yet by reverting to the old
RPC.

That makes sense. I tested the patches by cross-compiling the system and I did not thought about compatibility issues.

I'm attaching the modified patches (still trying to figure how to reply using git send-email). I added a new file_utimens RPC to handle timespecs in fs.defs and changed the glibc and translator implementations accordingly.

Note that I also added a two macros to convert between timespecs and time_value_t in libshouldbeinlibc/timefmt.h (one was taken from the exec server). Not sure if this is the best place.

Flavio

Samuel

glibc-futimens.patch
Description: Binary data

hurd-futimens.patch
Description: Binary data