[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Drop OTHERLIBS and use LDLIBS exclusively

From: Samuel Thibault
Subject: Re: [PATCH] Drop OTHERLIBS and use LDLIBS exclusively
Date: Thu, 31 Dec 2015 18:35:00 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Flavio Cruz, on Thu 31 Dec 2015 17:49:25 +0100, wrote:
> When cross-compiling, OTHERLIBS magically turns -lpthread into the path
> to the host libpthread.so file, resulting in build issues. LDLIBS does
> not suffer from this problem and it seems that is already being used in
> other Makefiles. This patch removes OTHERLIBS entirely from the build
> system.
> ---
> * Makeconf: Remove references to OTHERLIBS
> * auth/Makefile: Replace OTHERLIBS with LDLIBS.
> * boot/Makefile: Likewise.

It seems there is a misunderstanding :)

When I say "comments after ---", by "comments" I mean whatever
discussion that should not be recorded in git.  What should be recorded
in git (which includes the detailed changelog "* Makeconf: Remove
references" etc.) should go before ---.

I.e., when submitting a revised patch, either separate the discussion
part and the patch itself in separate mails, or keep them in just one
mail, but put the changelog of the patch before ---, and put the reply
to the discussion after the --- (yes it looks odd to human eyes, but
that's the way git am eats it).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]