Re: [PATCH] Fixed leaks in _netfs_translator_callback2_fn

[James Clarke]

> On 7 Feb 2016, at 23:10, Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Flávio Cruz, on Sun 07 Feb 2016 23:57:25 +0100, wrote:
>> Maybe here we should do it as follows:
>> 
>> err = errno;
>> netfs_release_peropen (po);
>> iohelp_free_iouser (user);
>> return err;
> 
> Yes, you never know what they could be doing to errno.
> 
> Samuel

Does that include changing

>   po = netfs_make_peropen (node, flags, cookie2);
>   if (! po)
> -    return errno;
> +    {
> +      iohelp_free_iouser (user);
> +      return errno;
> +    }

to

>   po = netfs_make_peropen (node, flags, cookie2);
>   if (! po)
> -    return errno;
> +    {
> +      err = errno;
> +      iohelp_free_iouser (user);
> +      return err;
> +    }

or can we assume the free functions don’t set errno?

James

signature.asc
Description: Message signed with OpenPGP using GPGMail