[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH hurd] build: Drop unused/unsubstituted config variables

From: Samuel Thibault
Subject: Re: [PATCH hurd] build: Drop unused/unsubstituted config variables
Date: Mon, 26 Jun 2017 08:36:43 +0200
User-agent: NeoMutt/20170113 (1.7.2)

David Michael, on dim. 25 juin 2017 23:24:52 -0700, wrote:
> * config.make.in (HAVE_BLKID, HAVE_DAEMON): Drop variable.
> Here is a cleanup of two lines that make config.make look like it has
> configure mistakes.


> I was really checking around for why "make install" is now broken with
> X11 enabled.  It looks like a4f5b76390f1c7b377efbac488b57fa6756da80a is
> just incorrect.  That commit prepends $(prefix) to the target for xkb
> file names, not directories, and only one of the three files to be
> installed.
> Even if it added $(prefix) consistently to XKB_BASE, the value of
> XKB_BASE is either from the xkeyboard-config.pc file which is the
> system's configured directory (so it seems wrong to add another prefix
> to it), or it defaults to "$datadir/X11/xkb" where "$datadir" should
> already be configured with "$prefix" included.
> Should a4f5b76390f1c7b377efbac488b57fa6756da80a just be reverted?  If
> that change is correct, can someone give me an example configuration
> where it can work?

Well, see with the commit's author :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]