[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Regarding local.css (mobile device support + overall readability)

From: Samuel Thibault
Subject: Re: Regarding local.css (mobile device support + overall readability)
Date: Wed, 13 Mar 2019 01:02:50 +0100
User-agent: NeoMutt/20170113 (1.7.2)


Muto, le dim. 10 mars 2019 19:05:15 -0600, a ecrit:
> The "Patches" section of the Hurd's Savannah project page, along with
> the hurd-web maling list have not been all that active lately, so just
> to make sure someone sees this, I want to start a discussion here

That was a good thing :) It seems I don't get notifications for this

> A few days ago, I sent a patch to the Hurd, which contains a
> CSS file that enhances the website's mobile view on all browsers that
> support @media (most browsers). I believe that this stylesheet improves
> the site considerably, not just for mobile viewers, but for everyone.
> Aside from just adding mobile support, I also added what I
> consider to be globally increased readibility, such as a
> background-color change on <pre> blocks, and a bold font weight on
> <code> tags. There are many such small changes like this that I would
> like feedback on. 

That looks nice, indeed, but submitting the final local.css file makes
it hard for us to review each piece of change. It'd be a lot easier for
us to look at it and commit what we agree on, if you submitted a patch

> Lastly, I know on the website it says specifically "do not hold back
> until the file is perfect. Make small code commits frequently", but I'm
> not sure how I'd go about that as someone without commit access (and I
> didn't want to spam up the "patches" section at Savannah with a
> hundred tiny changes).

A hundred tiny changes would be tedious to review, but a big one change
is complex to review as well. A good middleground is just to be found :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]