[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code

From: Joan Lledó
Subject: Re: [PATCH] - hurd pci-arbiter: remove embedded pciaccess code
Date: Sun, 27 Oct 2019 08:48:15 +0100 (CET)

Hello Hurd,

I made some changes to this patch:

1- I added a call to pci_system_cleanup(); in the shutdown RPC,
   so libpciaccess is shutdown correctly.

2- As now we're using libpciaccess functions to read/write
   from netfs_attempt_read/write, and these two libpciaccess
   functions have different prototypes, we cannot use one single
   pointer to function like we did until now, so I added some
   changes to use always the proper prototype.
   I hope it's not too much tricky.

3- I solved a warning Fix a -Wstringop-truncation warning.

4- I wrote a  changelog for the whole patch including Damien's work,
   except the change in S_pci_get_dev_rom() in pci-ops.c.
   I don't know what's this change for, but if we're always setting base_addr
   to 0, then probably we don't need that field anymore and can remove it from
   struct pci_xrom_bar.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]