[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] rumpkernel dependencies

From: Damien Zammit
Subject: Re: [PATCH] rumpkernel dependencies
Date: Fri, 10 Apr 2020 14:37:52 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

On 4/4/20 9:06 am, Samuel Thibault wrote:
> Well, rump does have it but doesn't install it (as well as dkio.h), but
> it should, shouldn't it?  Otherwise rump_sys_ioctl is basically unusable
> without it. It looks like makekernelheaders could be installing this?
> Probably we don't want all of them? Probably discussion can happen with
> upstream to know what they think about it? (I guess not being able to
> use ioctl is a good argument).

I can't contribute patches upstream to rump currently because netbsd
are planning to merge buildrump.sh into netbsd src/ tree and the "upstream"
rump repos will possibly be deprecated/merged into netbsd.
I believe we need to maintain our own rumpkernel debian tree for now until
they merge everything into src, then we can update rump properly.
I have been working on fixing UBSan errors in rump within netbsd upstream,
they're almost all fixed!

Can we keep the netbsd ioccom.h header for now in hurd?

+ifeq ($(HAVE_LIBRUMP),yes)


> Please make it automatically optional as I mentioned: either rump is
> detected and it is used, or it is not detected, and then anything that
> needs it is disabled.


>> +++ b/rumpdisk/Makefile
>> +rumpdisk.static: main.o block-rump.o
> I don't think this is needed? SRCS already provides the list of files to
> include.


>> +++ b/rumpdisk/block-rump.c
> Make the length a parameter, to avoid the magic assumption that it's


>> +/* FIXME:
>> + * Call rump_sys_aio_read/write and return MIG_NO_REPLY from
> Do mention only that long-term plan. Also mention rump_sys_pread/pwrite
> plan for multiple thread support. That's what we'll probably use short-
> and middle-term wise.



Attachment: 0001-rumpdisk-fixed.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]