[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] SMP initialization: detection and enumeration

From: jbranso
Subject: Re: [PATCH] SMP initialization: detection and enumeration
Date: Sun, 19 Jul 2020 17:01:25 +0000

Hey Almudena!

I quite admire your determination to work on the Hurd SMP! I would be terrified to try to work on something crazy cool like that. But as a friend told me recently, "No one cares about your theories and thoughts. People care about your actions. There were nights when I was doing a stand up comedy routine and failing miserably. BUT I KEPT AT IT! I learned though my mistakes. Courageous people act. They act often."

Thanks for being a role model for me to follow!


July 19, 2020 12:54 PM, "Almudena Garcia" <liberamenso10000@gmail.com> wrote:
Ok. I'll check the coding style. I'm trying to follow GNU style, but maybe I missed It in some files.
El dom., 19 jul. 2020 a las 18:49, Jessica Clarke (<jrtc27@jrtc27.com>) escribió:
On 19 Jul 2020, at 17:44, Almudena Garcia <liberamenso10000@gmail.com> wrote:
> Hi all:
> I attach a patch, with the code to find the cpus and enumerate them, reading from ACPI tables and MADT (APIC) tables.
> I've tested it over Qemu, but I recommends to test It before committing, anyway.
> You can find the rest of the work in my GitHub repository
> https://github.com/AlmuHS/GNUMach_SMP/tree/smp-new
> Check this, and advice me about errors or other necessary fixes

Before posting patches, please learn to go through and check you've
conformed to the code style, i.e. whitespace, comment styles etc. I see
a huge number of cases where those are not adhered to in your patch at a
glance. Having someone else point out all the issues is a huge waste of
time; better to fix them all yourself and then ask someone to review it
when they're not going to be constantly having to point out sloppiness.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]