[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T

From: Damien Zammit
Subject: Re: [PATCH 1/3] rumpdisk: define RUMP_REGISTER_T
Date: Mon, 20 Dec 2021 18:08:23 +1100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

Hi Samuel,

On 20/12/21 4:05 am, Samuel Thibault wrote:
> A commit log message needs to include the "why" of the commit.

Sorry, this is somewhat of a hack to work around a conflicting "register_t" 
We need to fix it in the librump configuration at compile time but I couldn't 
quite figure it out.

>> diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c
>> index 398289fb..8c29dc01 100644
>> --- a/rumpdisk/block-rump.c
>> +++ b/rumpdisk/block-rump.c
>> @@ -31,6 +31,7 @@
>>  #include <device/device.h>
>>  #define MACH_INCLUDE
>> +#define RUMP_REGISTER_T
> I don't understand: from what I can read in rumpkernel/, RUMP_REGISTER_T
> is to be the name of a type. If you define this to empty things will get
> completely wrong, won't they?

Yes, but it gets around the guard so doesn't try the wrong typedef.  I don't 
think we are using the typedef anywhere.
I wasn't sure how to fix it properly in librump's configuration (as above).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]