[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 12/15] fix warnings for 32 bit builds

From: Luca
Subject: Re: [PATCH 12/15] fix warnings for 32 bit builds
Date: Sun, 28 Aug 2022 09:59:25 +0200

Il 27/08/22 21:17, Samuel Thibault ha scritto:
Partially applied, thanks!

Luca Dariz, le mar. 28 juin 2022 12:10:51 +0200, a ecrit:
diff --git a/i386/i386at/biosmem.c b/i386/i386at/biosmem.c
index 78e7bb21..fafdc048 100644
--- a/i386/i386at/biosmem.c
+++ b/i386/i386at/biosmem.c
@@ -29,8 +29,6 @@
  #include <sys/types.h>
  #include <vm/vm_page.h>
-#define DEBUG 0
  #define __boot
  #define __bootdata
  #define __init

? It's used with #if DEBUG, so yes we do want it.

Ah, sorry, this must be a leftover from other local changes I have, and I still need to refine. For example, I added a --enable-debug option to configure, I'm not sure if this is better handled per-file or globally; for example, I'm currently enhancing the tracing part and this could touch multiple files, but it can also be a #define on its own.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]