bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 07/12 gnumach] Always use directed EOI and disable focus


From: Damien Zammit
Subject: [PATCH 07/12 gnumach] Always use directed EOI and disable focus
Date: Tue, 31 Jan 2023 09:37:55 +0000

---
 i386/i386/apic.c     | 4 +++-
 i386/i386at/ioapic.c | 9 ---------
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/i386/i386/apic.c b/i386/i386/apic.c
index 891ce288..ff7ba3e2 100644
--- a/i386/i386/apic.c
+++ b/i386/i386/apic.c
@@ -304,7 +304,9 @@ lapic_enable(void)

     /* Enable LAPIC to send or recieve IPI/SIPIs */
     dummy = lapic->spurious_vector.r;
-    lapic->spurious_vector.r = dummy | LAPIC_ENABLE;
+    lapic->spurious_vector.r = IOAPIC_SPURIOUS_BASE
+                            | LAPIC_ENABLE_DIRECTED_EOI
+                            | LAPIC_ENABLE;

     lapic->error_status.r = 0;

diff --git a/i386/i386at/ioapic.c b/i386/i386at/ioapic.c
index d4269ef0..003690ed 100644
--- a/i386/i386at/ioapic.c
+++ b/i386/i386at/ioapic.c
@@ -333,15 +333,6 @@ ioapic_configure(void)
     /* Start the IO APIC receiving interrupts */
     lapic_enable();

-    /* Enable IOAPIC processor focus */
-    lapic->spurious_vector.r |= LAPIC_FOCUS;
-
-    /* Enable directed EOI if applicable */
-    if (has_irq_specific_eoi || lapic->version.r & LAPIC_HAS_DIRECTED_EOI) {
-        has_irq_specific_eoi = 1;
-        lapic->spurious_vector.r |= LAPIC_ENABLE_DIRECTED_EOI;
-    }
-
     /* Set one-shot timer */
     lapic->divider_config.r = LAPIC_TIMER_DIVIDE_16;
     lapic->lvt_timer.r = IOAPIC_INT_BASE;
--
2.34.1





reply via email to

[Prev in Thread] Current Thread [Next in Thread]