[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach, hur

From: Sergey Bugaev
Subject: Re: [RFC PATCH glibc 33/34] hurd: Create abilist files for lib{mach, hurd}user
Date: Sun, 19 Mar 2023 18:39:20 +0300

On Sun, Mar 19, 2023 at 6:19 PM Samuel Thibault <samuel.thibault@gnu.org> wrote:
> Hello,
> Thanks for this work! :D

Yay! Can you believe just how glad I am to finally have completed it :D

> I don't have the time now to review the whole series, just a comment
> here: we don't really want to introduce abilist for lib{mach,hurd}user
> since their content will depend on the mach/hurd version glibc gets
> built against.

But isn't accidental ABI breakage (or unintended ABI additions)
exactly what the abilist mechanism is designed to guard against? It
doesn't even break your build (unlike -Werror) -- it's more of a lint.

You *would* want to know if your libhurduser.so build suddenly doesn't
include, say, proc_pid2task, because user code links to
lib{mach,hurd}user (via the libc.so linker script) and uses those
symbols, and would break if the symbols were to disappear.


Well in any case, the abilists aren't essential. Freel free to drop
this commit (and remove lib{mach,hurd}user.abilist from the next one)
if that was the wrong call.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]