Re: [PATCH 3/5] x86_64: format pusha/popa macros for readability

[Samuel Thibault]

Applied, thanks!

Luca Dariz, le sam. 29 juil. 2023 19:47:51 +0200, a ecrit:
> ---
>  x86_64/locore.S | 37 +++++++++++++++++++++++++++++++++++--
>  1 file changed, 35 insertions(+), 2 deletions(-)
> 
> diff --git a/x86_64/locore.S b/x86_64/locore.S
> index 413d43c4..7127957b 100644
> --- a/x86_64/locore.S
> +++ b/x86_64/locore.S
> @@ -39,8 +39,41 @@
>  #include <i386/i386/cpu_number.h>
>  #include <i386/i386/xen.h>
>  
> -#define pusha pushq %rax ; pushq %rcx ; pushq %rdx ; pushq %rbx ; subq 
> $8,%rsp ; pushq %rbp ; pushq %rsi ; pushq %rdi ; pushq %r8 ; pushq %r9 ; 
> pushq %r10 ; pushq %r11 ; pushq %r12 ; pushq %r13 ; pushq %r14 ; pushq %r15
> -#define popa popq %r15 ; popq %r14 ; popq %r13 ; popq %r12 ; popq %r11 ; 
> popq %r10 ; popq %r9 ; popq %r8 ; popq %rdi ; popq %rsi ; popq %rbp ; addq 
> $8,%rsp ; popq %rbx ; popq %rdx ; popq %rcx ; popq %rax
> +#define pusha                \
> +     pushq %rax      ;\
> +     pushq %rcx      ;\
> +     pushq %rdx      ;\
> +     pushq %rbx      ;\
> +     subq $8,%rsp    ;\
> +     pushq %rbp      ;\
> +     pushq %rsi      ;\
> +     pushq %rdi      ;\
> +     pushq %r8       ;\
> +     pushq %r9       ;\
> +     pushq %r10      ;\
> +     pushq %r11      ;\
> +     pushq %r12      ;\
> +     pushq %r13      ;\
> +     pushq %r14      ;\
> +     pushq %r15
> +
> +#define popa         \
> +     popq %r15       ;\
> +     popq %r14       ;\
> +     popq %r13       ;\
> +     popq %r12       ;\
> +     popq %r11       ;\
> +     popq %r10       ;\
> +     popq %r9        ;\
> +     popq %r8        ;\
> +     popq %rdi       ;\
> +     popq %rsi       ;\
> +     popq %rbp       ;\
> +     addq $8,%rsp    ;\
> +     popq %rbx       ;\
> +     popq %rdx       ;\
> +     popq %rcx       ;\
> +     popq %rax
>  
>  #ifdef USER32
>  #define PUSH_FSGS            \
> -- 
> 2.39.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.