bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] x86_64: remove unneeded segment selectors handling on fu


From: Samuel Thibault
Subject: Re: [PATCH 5/5] x86_64: remove unneeded segment selectors handling on full 64 bit
Date: Fri, 4 Aug 2023 23:50:40 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Luca Dariz, le sam. 29 juil. 2023 19:47:53 +0200, a ecrit:
> @@ -803,10 +809,7 @@ kern_return_t thread_getstatus(
>                               == 0)
>                           saved_state->efl &= ~EFL_IF;
>                   }
> -             }
> -             else
> -#endif
> -             {
> +             } else {
>                   /*
>                    * 386 mode.
>                    */
> @@ -815,6 +818,7 @@ kern_return_t thread_getstatus(
>                   state->fs = saved_state->fs & 0xffff;
>                   state->gs = saved_state->gs & 0xffff;
>               }
> +#endif

Mmm, I believe we shall then drop [gfed]s from i386_thread_state?
Otherwise we'll leak content in the structure in thread_getstatus calls.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]