[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] Avoid multiple definitions of copy_file_range

From: Samuel Thibault
Subject: Re: [PATCH 2/4] Avoid multiple definitions of copy_file_range
Date: Wed, 17 Jan 2024 16:22:30 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Manolo de Medici, le mer. 17 janv. 2024 16:08:34 +0100, a ecrit:
> Understood, but I cannot judge if it is a bug in qemu or it fixes
> another host os,
> since qemu doesn't target only glibc.

Yes, but freebsd too uses ssize_t:


glib mentions that it only exists on linux and freebsd.


> In order to avoid breaking other hosts, I consider it more cautious to
> ignore the difference.

Ignoring a bug is not a good thing on the long run :)

When there is something suspicious, it's useful to fix it.

> In the long term the Hurd is going to implement copy_file_range

Yes and by just fixing the prototype, we'll keep qemu able to
automatically use it when it becomes available.

Really, please, no tinkering, rather fix bugs.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]