bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1 hurd] ext2fs: New default: use xattrs to store translator


From: Samuel Thibault
Subject: Re: [PATCH 1/1 hurd] ext2fs: New default: use xattrs to store translator records
Date: Mon, 4 Mar 2024 00:33:08 +0100
User-agent: NeoMutt/20170609 (1.8.3)

Damien Zammit, le dim. 03 mars 2024 01:00:53 +0000, a ecrit:
>   - Legacy records still work with either setting.

Just to confirm: did you try to make an ext2fs built before this use the
xattr record? I.e. we can go back&forth between previous hurd package
and next hurd package?

Also,

if (sblock->s_creator_os != htole32 (EXT2_OS_HURD))
    return EOPNOTSUPP;

We don't want to require a hurd-created filesystem any more:

- if the creator os is hurd, then we can try to read di->i_translator
- if the xattr feature is enabled on the fs, then we can try to read the
gnu.translator xattr

It's only when the creator os is not hurd and the xattr feature is not
enabled on the fs, that we should return EOPNOTSUPP.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]