[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug-idutils] [PATCH 1/4] mkid: use ftello (not ftell) and fail if a
From: |
Jim Meyering |
Subject: |
Re: [bug-idutils] [PATCH 1/4] mkid: use ftello (not ftell) and fail if an offset is 2^32 or larger |
Date: |
Sun, 09 May 2010 21:59:33 +0200 |
Claudio Fontana wrote:
> On Sun, May 9, 2010 at 8:45 PM, Jim Meyering <address@hidden> wrote:
>> * src/mkid.c (write_id_file): Use ftello, not ftell.
>
> maybe a fallback to ftell should be needed in case ftello is not available?
> IIRC, while maintaining idutils for a short while, I was mailed by
> people using idutils with old linux versions. I don't know how old,
> but..
>
> The man page says
>
> CONFORMING TO
> SUSv2, POSIX.1-2001.
>
> NOTES
> These functions are found on System V-like systems. They are not
> present in libc4, libc5, glibc 2.0 but are available since glibc 2.1.
Hi Claudio,
Thanks for the review -- it's nice to know I'm not alone.
However, there's no need to worry. Gnulib provides a replacement
ftello function precisely to accommodate such deficient systems.