RE: white space after star unexpected

[Moore, Robert]

>Well .. .let's think ... what else is a * used for in C?
>Why wouldn't you want a space?

I believe that the Linux coding style is no space and this is what we
must adhere to.

>-----Original Message-----
>From: david ingamells [mailto:address@hidden
>Sent: Wednesday, June 18, 2008 11:13 AM
>To: Moore, Robert
>Cc: Lin, Ming M; bug-indent; Brown, Len
>Subject: Re: white space after star unexpected
>
>Moore, Robert wrote:
>> In a large subsystem with potentially hundreds of typedefs, this is a
>> problem.  Why is the space inserted in the first place?
>>
>> Bob
>>
>>
>>
>>> -----Original Message-----
>>> From: david ingamells [mailto:address@hidden
>>> Sent: Wednesday, June 18, 2008 8:30 AM
>>> To: Lin, Ming M
>>> Cc: bug-indent; Moore, Robert
>>> Subject: Re: white space after star unexpected
>>>
>>> Lin Ming wrote:
>>>
>>>> On Tue, 2008-06-17 at 17:41 +0200, david ingamells wrote:
>>>>
>>>>
>>>>> Lin Ming wrote:
>>>>>
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> When indent a C file with some "typedef struct", indent adds a
>>>>>> unexpected whitespace after "*".
>>>>>>
>>>>>> # cat test1.c
>>>>>> typedef struct mystruct s;
>>>>>>
>>>>>> void test(s *p);
>>>>>>
>>>>>> # indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs test1.c
>>>>>>
>>>>>> # cat test1.c
>>>>>> typedef struct mystruct s;
>>>>>>
>>>>>> void test(s * p);
>>>>>>              ^Here is an unexpected white space
>>>>>>
>>>>>>
>>>>>> # cat test2.c
>>>>>> typedef struct mystruct s;
>>>>>>
>>>>>> void foo()
>>>>>> {
>>>>>>  return;
>>>>>> }
>>>>>>
>>>>>> s test(struct mystruct *p);
>>>>>>
>>>>>> # indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs test2.c
>>>>>>
>>>>>> # cat test2.c
>>>>>> typedef struct mystruct s;
>>>>>>
>>>>>> void foo()
>>>>>> {
>>>>>>         return;
>>>>>> }
>>>>>>
>>>>>> s test(struct mystruct * p);
>>>>>>                         ^Here is an unexpected white space
>>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Lin Ming
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> bug-indent mailing list
>>>>>> address@hidden
>>>>>> http://lists.gnu.org/mailman/listinfo/bug-indent
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> #cat test1.c
>>>>> typedef struct mystruct s;
>>>>>
>>>>> void test(s *p);
>>>>>
>>>>> # indent -npro -kr -i8 -ts8 -sob -l80 -ss -ncs -T s test1.c
>>>>>
>>>>>
>>>> Thanks, but there are more than 200 typedefs in our project.
>>>> Not easy to specify each of them with -T.
>>>>
>>>> Is there another solution?
>>>>
>>>> Thanks,
>>>> Lin Ming
>>>>
>>>>
>>>>
>>>>> #cat test1.c
>>>>> typedef struct mystruct s;
>>>>>
>>>>> void test(s *p);
>>>>>
>>>>>
>>>>> # QED
>>>>>
>>>>>
>>>>
>>> indent does not know what a type is (apart from standard basic
types)
>>> unless you tell it.
>>>
>>>
>>
>>
>>
>Well .. .let's think ... what else is a * used for in C?
>Why wouldn't you want a space?