Re: [bug-inetutils] Build failure of telnetd in GNU/kFreeBSD.

[Guillem Jover]

Hi!

On Tue, 2010-11-02 at 23:53:06 +0100, Mats Erik Andersson wrote:
> I did a test run in GNU/kFreeBSD and came only as far
> as a compile failure of telnetd/telnetd.o:

>    make: Entering directory `/tmp/inetutils/telnetd'
>      CC     telnetd.o
>    In file included from telnetd.h:47,
>                     from telnetd.c:23:
>    /usr/include/stropts.h:67: error: conflicting types for 'rpl_ioctl'
>    ../lib/sys/ioctl.h:357: note: previous declaration of 'rpl_ioctl' was here
>    make: *** [telnetd.o] Error 1
>    make: Leaving directory `/tmp/inetutils/telnetd'

> The problem is that GNUlib defines a macro
> 
>    #define ioctl rpl_ioctl
> 
> which somehow works for GNU/Linux but not for GNU/kFreeBSD.

I applied this small workaround in Debian to get it building for
GNU/kFreeBSD. Sorry for not submitting it at the time, but as it was
just a hack it didn't seem appropriate.

--- a/telnetd/telnetd.h
+++ b/telnetd/telnetd.h
@@ -45,7 +45,7 @@
 #ifdef HAVE_SYS_PTYVAR_H
 # include <sys/ptyvar.h>
 #endif
-#ifdef HAVE_STROPTS_H
+#if 0
 # include <stropts.h>
 #endif
 #include <sys/ioctl.h>

The issue here is that GNUlib wraps the ioctl declaration within a local
<sys/ioctl.h> but it does not wrap <stropts.h>, and they declare ioctl
independently and thus get different and conflicting types.

regards,
guillem