Re: [bug-inetutils] rcp: No libshishi support.

[Mats Erik Andersson]

fredag den 10 februari 2012 klockan 16:17 skrev Simon Josefsson detta:
> Mats Erik Andersson <address@hidden> writes:
> 
> > Dear all,
> >
> > anyone for a well defined, finite task?
> >
> >   * Implement libshishi support in "src/rcp.c".
> >
> > or a step or two more complicated,
> >
> >   * Implement Kerberos5 support in "src/rcp.c".
> >
> > Presently on Kerberos4 is provided.
> 
> There is a re-implementation of rcp with Shishi support here:
> 
> http://git.savannah.gnu.org/cgit/shishi.git/tree/extra/rsh-redone
> 
> Come to think of it, maybe it makes sense to move some of that into
> InetUtils, the rcp code in InetUtils is quite crufty...

Until then you MUST disable the build of rcp when using "--with-shi-shi",
since you are fooling user to believe there is a functional support for
libshishi in that utility, which is a plain lie.

> 
> However, there is always the backwards compatibility issue to consider,
> and without good regression testing it is difficult to know whether our
> "rcp" works or not.  Since rcp is so rarely used today, I'm not sure
> we'd get many bug reports about it...

Speaking of which

   /* src/rshd.c, lines 796 -- 810
      `git blame` mentions Alfred
    */

   #elif defined(SHISHI)
     if (use_kerberos)
       {
         /*
            Verbatim code from Kerberos clause,
            ten lines in extent, suggesting that
            user authentication be implemented here.
          */
       }
     else
   #endif

Is this functional at all, or is it yet another lie? Code that
has not been tested, based on hope alone? For sure it compiles,
but the code does nothing. Should no action be needed, then this
is the worst possible mode of stating that fact.

Regards,
  Mats