Re: [platform-testers] inetutils-2.5.90 released [alpha]

[Collin Funk]

Hi Bruno,

Bruno Haible <bruno@clisp.org> writes:

> (It doesn't take your tarball. It build off the git repository. But that
> should be sufficiently close.)
>
> Here are my findings so far:

Thanks! Also, before a release I want to fix these warnings that I
noticed.

process.c:224:50: warning: argument to 'sizeof' in 'strncmp' call is the same 
expression as the first source; did you mean to provide an explicit length? 
[-Wsizeof-pointer-memaccess]
  224 |       if (!strncmp (UT_USER (uptr), name, sizeof (UT_USER (uptr))))
      |                                                  ^

And again:

syslogd.c:1648:43: warning: argument to 'sizeof' in 'strncpy' call is the same 
expression as the source; did you mean to provide an explicit length? 
[-Wsizeof-pointer-memaccess]
 1648 |       strncpy (line, utp->ut_line, sizeof (utp->ut_line));
      |                                           ^
syslogd.c:1666:30: warning: argument to 'sizeof' in 'strncmp' call is the same 
expression as the second source; did you mean to provide an explicit length? 
[-Wsizeof-pointer-memaccess]
 1666 |                       sizeof (UT_USER (utp))))
      |                              ^

I've been meaning to fix these after noticing them recently, but I'm not
very familiar with readutmp. Perhaps this code was for ancient versions
of the module?

Collin